Bug 152212

Summary: Web Inspector: "Selected Element" should use sans-serif font, not monospace
Product: WebKit Reporter: Nikita Vasilyev <nvasilyev>
Component: Web InspectorAssignee: Nikita Vasilyev <nvasilyev>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[Animated GIF] Actual/expected
none
Patch
none
[Animated GIF] Actual/expected
none
Patch none

Description Nikita Vasilyev 2015-12-11 22:08:48 PST
Created attachment 267220 [details]
[Animated GIF] Actual/expected

"Selected Element" isn't code and isn't editable. It shouldn't be monospace.
Comment 1 Radar WebKit Bug Importer 2015-12-11 22:09:04 PST
<rdar://problem/23870644>
Comment 2 Nikita Vasilyev 2015-12-11 22:10:10 PST
Created attachment 267221 [details]
Patch
Comment 3 Joseph Pecoraro 2015-12-12 00:16:12 PST
Err, in the gif the sans-serif version looks too fat to me. The blue background grew up and down, and it looks unbalanced around the text.
Comment 4 Nikita Vasilyev 2015-12-12 00:39:26 PST
Created attachment 267229 [details]
[Animated GIF] Actual/expected

(In reply to comment #3)
> Err, in the gif the sans-serif version looks too fat to me. The blue
> background grew up and down, and it looks unbalanced around the text.

Now?
Comment 5 Nikita Vasilyev 2015-12-12 00:41:04 PST
Created attachment 267230 [details]
Patch
Comment 6 Timothy Hatcher 2015-12-12 08:46:13 PST
New version looks better.
Comment 7 WebKit Commit Bot 2015-12-12 09:32:39 PST
Comment on attachment 267230 [details]
Patch

Clearing flags on attachment: 267230

Committed r194008: <http://trac.webkit.org/changeset/194008>
Comment 8 WebKit Commit Bot 2015-12-12 09:32:43 PST
All reviewed patches have been landed.  Closing bug.