Bug 152202

Summary: Reconsider B3's constant motion policy
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, benjamin, commit-queue, ggaren, keith_miller, mark.lam, mhahnenb, msaboff, oliver, saam, sam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 150279    
Attachments:
Description Flags
the patch
none
the patch ggaren: review+

Filip Pizlo
Reported 2015-12-11 16:19:27 PST
It appears that on asm.js code, our constant motion is wrong: - It pins tags to registers even though the tags are not used frequently enough to warrant it. - It doesn't pin the heap base to a register even though it is used frequently enough to warrant it.
Attachments
the patch (23.35 KB, patch)
2016-01-19 12:40 PST, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (22.78 KB, patch)
2016-01-19 12:44 PST, Filip Pizlo 		ggaren: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2015-12-11 16:20:41 PST
*** Bug 152107 has been marked as a duplicate of this bug. ***
Filip Pizlo
Comment 2 2016-01-19 12:40:58 PST
Created attachment 269282 [details] the patch
Filip Pizlo
Comment 3 2016-01-19 12:44:35 PST
Created attachment 269283 [details] the patch
Geoffrey Garen
Comment 4 2016-01-19 12:54:19 PST
Comment on attachment 269283 [details] the patch r=me
Filip Pizlo
Comment 5 2016-01-19 12:55:58 PST
Landed in http://trac.webkit.org/changeset/195307
Note You need to log in before you can comment on or make changes to this bug.