Bug 152196

Summary: Perf dashboard's buildbot sync config JSON duplicates too much information
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: Perf DashboardAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, dewei_zhu, jond, rniwa, slewis, timothy
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Added shared configurations slewis: review+

Ryosuke Niwa
Reported 2015-12-11 15:52:58 PST
Consolidate the duplicated entries.
Attachments
Added shared configurations (2.10 KB, patch)
2015-12-11 15:56 PST, Ryosuke Niwa 		slewis: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2015-12-11 15:56:31 PST
Created attachment 267196 [details] Added shared configurations
dewei_zhu
Comment 2 2015-12-11 15:59:46 PST
Comment on attachment 267196 [details] Added shared configurations This will definitely simplify the process of enabling a new test. Is the data format documented anywhere?
Stephanie Lewis
Comment 3 2015-12-11 16:07:40 PST
Comment on attachment 267196 [details] Added shared configurations View in context: https://bugs.webkit.org/attachment.cgi?id=267196&action=review > Websites/perf.webkit.org/tools/sync-with-buildbot.py:78 > + config[key].update(value) Would we ever have a list?
Ryosuke Niwa
Comment 4 2015-12-11 16:11:54 PST
Comment on attachment 267196 [details] Added shared configurations View in context: https://bugs.webkit.org/attachment.cgi?id=267196&action=review >> Websites/perf.webkit.org/tools/sync-with-buildbot.py:78 >> + config[key].update(value) > > Would we ever have a list? If we did have a list, then overriding the old list with the new one (not merging is the right approach so the code below (config[key] = value) will suffice.
Ryosuke Niwa
Comment 5 2015-12-11 16:12:00 PST
Committed r193992: <http://trac.webkit.org/changeset/193992>
Note You need to log in before you can comment on or make changes to this bug.