Bug 152185

Summary: Refactoring to reduce potential cut-paste errors with the FTL ICs.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, keith_miller, msaboff, saam
Priority: P2    
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch.
none
patch 2: revert unneeded part where I pushed m_name down to InlineCacheDescriptor. saam: review+

Description Mark Lam 2015-12-11 13:32:01 PST 
Patch coming.
Comment 1 Mark Lam 2015-12-11 13:49:29 PST 
Created attachment 267185 [details]
proposed patch.
Comment 2 WebKit Commit Bot 2015-12-11 13:51:00 PST 
Attachment 267185 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/ftl/FTLInlineCacheDescriptor.h:92:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/ftl/FTLInlineCacheDescriptor.h:150:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/ftl/FTLInlineCacheDescriptor.h:243:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
Total errors found: 3 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Mark Lam 2015-12-11 14:40:33 PST 
Created attachment 267190 [details]
patch 2: revert unneeded part where I pushed m_name down to InlineCacheDescriptor.
Comment 4 Saam Barati 2015-12-11 14:59:43 PST 
Comment on attachment 267190 [details]
patch 2: revert unneeded part where I pushed m_name down to InlineCacheDescriptor.

r=me
Comment 5 Mark Lam 2015-12-11 15:03:12 PST 
Thanks for the review.  Landed in r193985: <http://trac.webkit.org/r193985>.