|Summary:||REGRESSION (r191613): Web Inspector: Can't type spaces when editing DOM nodes|
|Product:||WebKit||Reporter:||Michael Bailey <bugzilla>|
|Component:||Web Inspector||Assignee:||Joseph Pecoraro <joepeck>|
|Severity:||Normal||CC:||bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer|
|Version:||WebKit Nightly Build|
|OS:||OS X 10.11|
Description Michael Bailey 2015-12-11 06:50:37 PST
At some point recently, I stopped being able to type spaces when editing DOM nodes in the Web Inspector's "Elements" tab. Typing any other character works, and I can work around the issue by copying and pasting spaces. STR: 1. Open the Web Inspector to the "Elements" tab. 2. Double click any element or text node to edit its contents. 3. Press the space bar. Expected: Spaces should be typed into the selected field. Actual: Nothing happens. This works as expected in Safari 9.0.2 (11601.3.9), but is broken in WebKit r193949. I think it broke within the last couple weeks.
Comment 2 Nikita Vasilyev 2015-12-11 22:01:15 PST
Bisecting tells me that the regression was introduced by: http://trac.webkit.org/changeset/191613
Comment 3 Joseph Pecoraro 2015-12-11 23:00:12 PST
(In reply to comment #2) > Bisecting tells me that the regression was introduced by: > http://trac.webkit.org/changeset/191613 Really? Hah. I wonder if the keyboard shortcuts should start out disabled, since they are only meant to be enabled / disabled when the TabContentView is shown, but they don't look disabled when created.
Comment 4 Joseph Pecoraro 2015-12-12 00:06:31 PST
Created attachment 267228 [details] [PATCH] Proposed Fix
Comment 5 WebKit Commit Bot 2015-12-12 09:37:58 PST
Comment on attachment 267228 [details] [PATCH] Proposed Fix Clearing flags on attachment: 267228 Committed r194009: <http://trac.webkit.org/changeset/194009>
Comment 6 WebKit Commit Bot 2015-12-12 09:38:02 PST
All reviewed patches have been landed. Closing bug.