Bug 152146

Summary: Remove additional simulator checks before running layout-tests
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, commit-queue, dbates, glenn, lforschler
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=141718
https://bugs.webkit.org/show_bug.cgi?id=151243
Attachments:
Description Flags
Proposed patch none

Aakash Jain
Reported 2015-12-10 11:50:47 PST
Some of the checks like booting up and shutting down the simulator device are no longer required. Now we are creating a new simulator device and new copy of Simulator app in each run, as opposed to earlier setup in which we were reusing the old Simulator. These additional checks takes a lot of time (especially in multi-simulator environment) and doesn't add much values. We should remove these checks.
Attachments
Proposed patch (3.38 KB, patch)
2015-12-10 11:59 PST, Aakash Jain 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2015-12-10 11:59:01 PST
Created attachment 267117 [details] Proposed patch
WebKit Commit Bot
Comment 2 2015-12-10 12:45:17 PST
Comment on attachment 267117 [details] Proposed patch Clearing flags on attachment: 267117 Committed r193923: <http://trac.webkit.org/changeset/193923>
WebKit Commit Bot
Comment 3 2015-12-10 12:45:21 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.