Bug 152124

Summary: [B3] Make GCC ignore warnings in FTLB3Output.h
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: JavaScriptCoreAssignee: Csaba Osztrogonác <ossy>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, fpizlo, keith_miller, mark.lam, msaboff, saam
Priority: P2    
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 152248    
Attachments:
Description Flags
Patch none

Csaba Osztrogonác
Reported 2015-12-10 06:01:36 PST
Clang already ignores missing-noreturn and unused-parameter warnings in FTLB3Output.h because of clang pragmas inside COMPILER(CLANG) But these warnings should be ignored by GCC too. Let's make these pragmas GCC and Clang friendly.
Attachments
Patch (1.92 KB, patch)
2015-12-10 06:02 PST, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2015-12-10 06:02:52 PST
Created attachment 267100 [details] Patch
Mark Lam
Comment 2 2015-12-10 07:18:20 PST
Comment on attachment 267100 [details] Patch r=me
WebKit Commit Bot
Comment 3 2015-12-10 08:04:48 PST
Comment on attachment 267100 [details] Patch Clearing flags on attachment: 267100 Committed r193904: <http://trac.webkit.org/changeset/193904>
WebKit Commit Bot
Comment 4 2015-12-10 08:04:53 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.