Bug 152103

Summary:

REGRESSION: code-review-tests.html fails with error "Received an error at line 214"

Product:

WebKit

Reporter:

Daniel Bates <dbates>

Component:

Tools / Tests

Assignee:

Daniel Bates <dbates>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aestes, ddkilzer, joepeck, lforschler

Priority:

Version:

WebKit Local Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	darin: review+

Daniel Bates

Reported 2015-12-09 19:32:50 PST

The unit tests in the file code-review-tests.html fail due to a JavaScript TypeError. Steps to reproduce: 1. Open the page Websites/bugs.webkit.org/code-review-test.html, <http://trac.webkit.org/export/193888/trunk/Websites/bugs.webkit.org/code-review-test.html>. Then the following text can be seen on the page: "FAIL: Received an error at line 214" And in the console we see the following error: [Error] TypeError: undefined is not an object (evaluating '$('.overallComments textarea').val().trim') _json (code-review.js:213) save (code-review.js:253) saveDraftComments (code-review.js:333) acceptComment (code-review.js:1450) testSaveCommentsWithMissingLineIds (code-review-test.html:445) (anonymous function) (code-review-test.html:460) I am using Safari Version 9.0.2 (11601.3.9) on OS X 10.11.2 (15C49).

Attachments
Patch (3.78 KB, patch) 2015-12-09 19:36 PST, Daniel Bates	darin: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Daniel Bates

Comment 1 2015-12-09 19:36:02 PST

Created attachment 267065 [details] Patch

Daniel Bates

Comment 2 2015-12-09 19:43:09 PST

Committed r193889: <http://trac.webkit.org/changeset/193889>

Note You need to log in before you can comment on or make changes to this bug.