Bug 152090

Summary:

<video>/<audio> should make use of the parsed media attribute on sources

Product:

WebKit

Reporter:

Dave Hyatt <hyatt>

Component:

Media

Assignee:

Dave Hyatt <hyatt>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

eric.carlson, hyatt, jer.noble, mcatanzaro, ossy

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	darin: review+

Description Dave Hyatt 2015-12-09 12:43:10 PST

<video>/<audio> should make use of the parsed media attribute on sources now that we have cached it in a parsed form for <picture> support.

See https://bugs.webkit.org/show_bug.cgi?id=152013

Comment 1 Dave Hyatt 2015-12-10 12:09:29 PST

Created attachment 267118 [details]
Patch

Comment 2 Darin Adler 2015-12-10 12:13:02 PST

Comment on attachment 267118 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=267118&action=review

> Source/WebCore/html/HTMLMediaElement.cpp:4150
> +            RefPtr<MediaQuerySet> media = source->mediaQuerySet();

Does this need to go into a local variable at all? Can’t we just use this below directly?

> Source/WebCore/html/HTMLSourceElement.cpp:34
> +#if ENABLE(VIDEO)
>  #include "HTMLMediaElement.h"
> +#endif

If we are making this conditional we should put it in a separate paragraph below.

Does the include itself need to be conditional?

Comment 3 Dave Hyatt 2016-01-04 13:18:58 PST

Fix landed in r194549.

Comment 4 Csaba Osztrogonác 2016-01-05 00:53:18 PST

(In reply to comment #3)
> Fix landed in r194549.

The commit log was repeated 47 times. :( Dave, could you check your script?