Bug 152068

Summary: [CoordinatedGraphics] Remove unnecessary guards in CoordinatedDrawingArea
Product: WebKit Reporter: Ryuan Choi <ryuan.choi>
Component: WebKit EFLAssignee: Ryuan Choi <ryuan.choi>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, lucas.de.marchi
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Ryuan Choi
Reported 2015-12-09 08:06:05 PST
CoordinatedDrawingArea is only for UI side compositor of CoordinatedGraphics. So, COORDINATED_GRAPHICS_MULTIPROCESS guards are not necessary.
Attachments
Patch (5.60 KB, patch)
2015-12-09 08:08 PST, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
Patch (5.60 KB, patch)
2015-12-09 08:09 PST, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ryuan Choi
Comment 1 2015-12-09 08:08:23 PST
Created attachment 267007 [details] Patch
Ryuan Choi
Comment 2 2015-12-09 08:09:40 PST
Created attachment 267008 [details] Patch
Gyuyoung Kim
Comment 3 2015-12-09 08:56:49 PST
Comment on attachment 267008 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=267008&action=review > Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedDrawingArea.h:-71 > -#if USE(TEXTURE_MAPPER_GL) && PLATFORM(GTK) Should this interface be removed as well ?
Ryuan Choi
Comment 4 2015-12-09 09:01:29 PST
Comment on attachment 267008 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=267008&action=review >> Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedDrawingArea.h:-71 >> -#if USE(TEXTURE_MAPPER_GL) && PLATFORM(GTK) > > Should this interface be removed as well ? DrawingAreaImpl still use it while CoordinatedDrawingArea does not use it now. But, yoon should confirm this, IMO.
Gyuyoung Kim
Comment 5 2015-12-09 09:43:38 PST
Comment on attachment 267008 [details] Patch rs=me. yoon confirmed to remove *setNativeSurfaceHandleForComposting()*.
WebKit Commit Bot
Comment 6 2015-12-09 10:32:43 PST
Comment on attachment 267008 [details] Patch Clearing flags on attachment: 267008 Committed r193843: <http://trac.webkit.org/changeset/193843>
WebKit Commit Bot
Comment 7 2015-12-09 10:32:48 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.