Bug 152011

Summary: DFG::UnificationPhase should merge isProfitableToUnbox, since this may have been set in ByteCodeParser
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, benjamin, commit-queue, ggaren, keith_miller, mark.lam, mhahnenb, msaboff, nrotem, oliver, saam, sam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
the patch msaboff: review+

Filip Pizlo
Reported 2015-12-08 12:34:54 PST
Previously UnificationPhase did not merge this because we used to only set this in FixupPhase, which runs after unification. But now ByteCodeParser may set isProfitableToUnbox, so UnificationPhase needs to merge it after unifying.
Attachments
the patch (2.98 KB, patch)
2015-12-08 12:37 PST, Filip Pizlo 		msaboff: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2015-12-08 12:37:00 PST
Created attachment 266928 [details] the patch
Michael Saboff
Comment 2 2015-12-08 13:18:17 PST
Comment on attachment 266928 [details] the patch r=me
Filip Pizlo
Comment 3 2015-12-08 13:46:37 PST
Landed in http://trac.webkit.org/changeset/193782
Note You need to log in before you can comment on or make changes to this bug.