Bug 152000

Summary: [MediaStream] MediaDeviceInfo.label must be empty unless the user has granted permission to access device
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: MediaAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 152001, 152087    
Bug Blocks:    
Attachments:
Description Flags
Proposed patch. none

Eric Carlson
Reported 2015-12-08 10:38:36 PST
MediaDeviceInfo.label must be empty if none of the local devices are attached to an active MediaStreamTrack in the current browsing context, and if no persistent permission to access the devices has been granted to the page's origin.
Attachments
Proposed patch. (38.54 KB, patch)
2015-12-23 12:12 PST, Eric Carlson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Carlson
Comment 1 2015-12-23 12:12:15 PST
Created attachment 267850 [details] Proposed patch. Include label when the document has had an active media stream track.
Radar WebKit Bug Importer
Comment 2 2015-12-23 13:53:47 PST
<rdar://problem/24001637>
Brent Fulgham
Comment 3 2015-12-23 14:35:33 PST
Comment on attachment 267850 [details] Proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=267850&action=review Looks good. I had a couple of minor nits below. > Source/WebCore/ChangeLog:28 > + (WebCore::mediaStreams): Deleted. Drive-by cleanup: moved list of all streams MediaStreamRegistry. moved list of all streams *to* MediaStreamRegistry? > Source/WebCore/Modules/mediastream/MediaStream.cpp:240 > + if (Document *document = downcast<Document>(scriptExecutionContext())) Document* document!
Eric Carlson
Comment 4 2015-12-23 14:48:51 PST
(In reply to comment #3) > Comment on attachment 267850 [details] > > > Source/WebCore/ChangeLog:28 > > + (WebCore::mediaStreams): Deleted. Drive-by cleanup: moved list of all streams MediaStreamRegistry. > > moved list of all streams *to* MediaStreamRegistry? > Fixed. > > Source/WebCore/Modules/mediastream/MediaStream.cpp:240 > > + if (Document *document = downcast<Document>(scriptExecutionContext())) > > Document* document! Oops, fixed. Thanks!
Eric Carlson
Comment 5 2015-12-23 14:53:08 PST
Committed r194397: https://trac.webkit.org/r194397
Note You need to log in before you can comment on or make changes to this bug.