Bug 151996

Summary: [iOS] Adopt WebFullScreenVideoRootViewController.
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, mitz
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
mitz: review+
Patch for landing none

Jer Noble
Reported 2015-12-08 09:59:07 PST
[iOS] Adopt WebFullScreenVideoRootViewController.
Attachments
Patch (3.17 KB, patch)
2015-12-08 10:03 PST, Jer Noble 		mitz: review+
DetailsFormatted DiffDiff
Patch for landing (3.12 KB, patch)
2015-12-08 10:28 PST, Jer Noble 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2015-12-08 10:03:26 PST
Created attachment 266902 [details] Patch
WebKit Commit Bot
Comment 2 2015-12-08 10:04:54 PST
Attachment 266902 [details] did not pass style-queue: ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:84: *SoftLink.h header should be included after all other headers. [build/include_order] [4] ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:94: Missing space before { [whitespace/braces] [5] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
mitz
Comment 3 2015-12-08 10:09:11 PST
Comment on attachment 266902 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=266902&action=review > Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:83 > +#if __has_include(<WebKitAdditions/WebFullScreenVideoRootViewController.m>) Instead of checking for the presence of the header, you should check for __IPHONE_OS_VERSION_MIN_REQUIRED >= 101200 && USE(APPLE_INTERNAL_SDK).
mitz
Comment 4 2015-12-08 10:13:59 PST
(In reply to comment #3) > Instead of checking for the presence of the header, you should check for > __IPHONE_OS_VERSION_MIN_REQUIRED >= 101200 && USE(APPLE_INTERNAL_SDK). Sorry, ignore the __IPHONE_OS_VERSION_MIN_REQUIRED part! Just check for USE(APPLE_INTERNAL_SDK).
Jer Noble
Comment 5 2015-12-08 10:28:06 PST
Created attachment 266907 [details] Patch for landing
WebKit Commit Bot
Comment 6 2015-12-08 11:09:51 PST
Attachment 266907 [details] did not pass style-queue: ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:84: *SoftLink.h header should be included after all other headers. [build/include_order] [4] ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:94: Missing space before { [whitespace/braces] [5] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Jer Noble
Comment 7 2015-12-08 11:11:29 PST
Committed r193760: <http://trac.webkit.org/changeset/193760>
Note You need to log in before you can comment on or make changes to this bug.