Bug 151960 – [WK2] Regression(r187691): If a page is showing an auth pane in one tab, any new tabs with same page hang until credentials are entered in first tab

• Component: WebKit2
• Status: RESOLVED FIXED

[Chris Dumez]

If a page is showing an auth pane in one tab, any new tabs with same page hang until credentials are entered in first tab. This is a regression from <http://trac.webkit.org/changeset/187691>.

[Chris Dumez]

rdar://problem/23618112

[Chris Dumez]

Created attachment 266800 [details]
Patch

[Alex Christensen]

Comment on attachment 266800 [details]
Patch

r=me

[Alexey Proskuryakov]

Comment on attachment 266800 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=266800&action=review

> Source/WebKit2/ChangeLog:14
> +        same domain, no matter what tab they are for. This can be confusing
> +        so we now only coalesce authentication challenges within each tab,
> +        by leveraging the pageID (in addition to the domain).

Hmm, so this means that the user will once again get a ton of authentication requests when relaunching Safari. That's not a good experience either.

[Chris Dumez]

(In reply to comment #4)
> Comment on attachment 266800 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=266800&action=review
> 
> > Source/WebKit2/ChangeLog:14
> > +        same domain, no matter what tab they are for. This can be confusing
> > +        so we now only coalesce authentication challenges within each tab,
> > +        by leveraging the pageID (in addition to the domain).
> 
> Hmm, so this means that the user will once again get a ton of authentication
> requests when relaunching Safari. That's not a good experience either.

Well, before coalescing, they would get several auth panes per tab. Now they can get maximum one auth pane per tab. I think this is a good compromise.

The situation where you end up having blank tabs stuck due to an authentication request in another tab (that is not visible) is worse IMHO.

[WebKit Commit Bot]

Comment on attachment 266800 [details]
Patch

Clearing flags on attachment: 266800

Committed r193654: <http://trac.webkit.org/changeset/193654>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.