Bug 151955

Summary: FTL B3 should be able to flag the tag constants as being super important so that B3 can hoist them and Air can force them into registers
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, barraclough, benjamin, cdumez, cmarcelo, commit-queue, ggaren, keith_miller, mark.lam, mhahnenb, msaboff, nrotem, oliver, ossy, peavo, saam, sam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 150279    
Attachments:
Description Flags
work in progress
none
it's starting to work
none
the patch
none
the patch ggaren: review+

Description Filip Pizlo 2015-12-07 12:27:39 PST 
Patch forthcoming.
Comment 1 Filip Pizlo 2015-12-07 13:05:38 PST 
Created attachment 266801 [details]
work in progress
Comment 2 Filip Pizlo 2015-12-07 16:05:00 PST 
Created attachment 266825 [details]
it's starting to work
Comment 3 Filip Pizlo 2015-12-07 16:37:34 PST 
Created attachment 266831 [details]
the patch
Comment 4 Filip Pizlo 2015-12-07 16:38:51 PST 
Created attachment 266832 [details]
the patch

For real this time.
Comment 5 Geoffrey Garen 2015-12-07 16:53:54 PST 
Comment on attachment 266832 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=266832&action=review

r=me

> Source/JavaScriptCore/b3/B3CFG.h:39
> +public:

WTF_MAKE_FAST_ALLOCATED
Comment 6 Filip Pizlo 2015-12-07 18:46:15 PST 
(In reply to comment #5)
> Comment on attachment 266832 [details]
> the patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=266832&action=review
> 
> r=me
> 
> > Source/JavaScriptCore/b3/B3CFG.h:39
> > +public:
> 
> WTF_MAKE_FAST_ALLOCATED

Fixed!
Comment 7 Filip Pizlo 2015-12-07 18:47:14 PST 
Landed in http://trac.webkit.org/changeset/193682
Comment 8 Csaba Osztrogonác 2015-12-08 01:42:15 PST 
(In reply to comment #7)
> Landed in http://trac.webkit.org/changeset/193682

It broke the WinCairo build: 
https://build.webkit.org/builders/WinCairo%2064-Bit%20Release/builds/51858

(cc-ing port maintainers)