Bug 151884

Summary: [Cocoa] Some fonts cause CTFontCopyAvailableTables() to return nullptr
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, fred.wang, jonlee, simon.fraser, thorton, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Myles C. Maxfield
Reported 2015-12-04 14:04:56 PST
[Cocoa] Some fonts cause CTFontCopyAvailableTables() to return nullptr
Attachments
Patch (1.55 KB, patch)
2015-12-04 14:05 PST, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (1.59 KB, patch)
2015-12-04 14:07 PST, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2015-12-04 14:05:47 PST
Created attachment 266659 [details] Patch
Myles C. Maxfield
Comment 2 2015-12-04 14:06:54 PST
<rdar://problem/23752253>
Myles C. Maxfield
Comment 3 2015-12-04 14:07:25 PST
Created attachment 266660 [details] Patch
Myles C. Maxfield
Comment 4 2015-12-04 14:14:38 PST
fredw says there may be similar code elsewhere that needs to be updated.
Myles C. Maxfield
Comment 5 2015-12-04 14:16:34 PST
fontHasVerticalGlyphs()
Blaze Burg
Comment 6 2015-12-04 15:03:08 PST
Comment on attachment 266660 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=266660&action=review rs=me > Source/WebCore/platform/graphics/opentype/OpenTypeCG.cpp:44 > CFIndex numTables = CFArrayGetCount(tableTags.get()); I would add a newline below the return. Not sure how dense your corner of WebKit is. :)
WebKit Commit Bot
Comment 7 2015-12-04 15:52:44 PST
Comment on attachment 266660 [details] Patch Clearing flags on attachment: 266660 Committed r193484: <http://trac.webkit.org/changeset/193484>
WebKit Commit Bot
Comment 8 2015-12-04 15:52:47 PST
All reviewed patches have been landed. Closing bug.
Myles C. Maxfield
Comment 9 2016-01-04 13:27:29 PST
Committed r194551: <http://trac.webkit.org/changeset/194551>
Note You need to log in before you can comment on or make changes to this bug.