Bug 151861

Summary: Source/JavaScriptCore/create_hash_table shouldn't be too verbose
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: New BugsAssignee: Csaba Osztrogonác <ossy>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, keith_miller, mark.lam, msaboff, saam
Priority: P2    
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
build log with the proposed change
none
build log without the proposed change none

Csaba Osztrogonác
Reported 2015-12-04 05:31:09 PST
create_hash_table fills the build logs with 32 useless lines like this: Creating hashtable for /home/ossy/WebKit/Source/JavaScriptCore/runtime/IntlDateTimeFormatConstructor.cpp I don't think is is so useful for us. Additionally it makes the one-liner ninja output longer for nothing. If you really need verbose output, ninja already dumps lines like this: Generating ../../DerivedSources/JavaScriptCore/IntlDateTimeFormatConstructor.lut.h
Attachments
Patch (1.21 KB, patch)
2015-12-04 05:32 PST, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
build log with the proposed change (17.28 KB, text/plain)
2015-12-04 05:34 PST, Csaba Osztrogonác 		no flags
Details
build log without the proposed change (22.82 KB, text/plain)
2015-12-04 05:38 PST, Csaba Osztrogonác 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2015-12-04 05:32:52 PST
Created attachment 266623 [details] Patch
Csaba Osztrogonác
Comment 2 2015-12-04 05:34:51 PST
Created attachment 266624 [details] build log with the proposed change
Csaba Osztrogonác
Comment 3 2015-12-04 05:38:13 PST
Created attachment 266625 [details] build log without the proposed change
WebKit Commit Bot
Comment 4 2015-12-10 04:02:03 PST
Comment on attachment 266623 [details] Patch Clearing flags on attachment: 266623 Committed r193900: <http://trac.webkit.org/changeset/193900>
WebKit Commit Bot
Comment 5 2015-12-10 04:02:07 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.