Bug 151828

Summary:

Web Inspector: Specifically Identify the Global Lexical Environment Scope

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

Web Inspector

Assignee:

Joseph Pecoraro <joepeck>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, commit-queue, graouts, joepeck, keith_miller, mark.lam, mattbaker, msaboff, nvasilyev, saam, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
[IMAGE] With Fix	none
[PATCH] Proposed Fix	joepeck: review-
[PATCH] Proposed Fix	bburg: review+

Description Joseph Pecoraro 2015-12-03 14:57:23 PST

* SUMMARY
Specifically Identify the Global Lexical Environment Scope.

* STEPS TO REPRODUCE
1. shell> run-webkit-tests inspector/debugger/breakpoint-scopes.html
  => There is a new Closure Scope right above Global Variables, should be better named

* NOTES
Test is currently skipped because all debugger tests are errantly skipped right now.

Comment 1 Radar WebKit Bug Importer 2015-12-03 14:57:54 PST

<rdar://problem/23750617>

Comment 2 Joseph Pecoraro 2015-12-03 14:58:05 PST

Created attachment 266564 [details]
[IMAGE] With Fix

Comment 3 Joseph Pecoraro 2015-12-03 15:02:49 PST

Created attachment 266565 [details]
[PATCH] Proposed Fix

Comment 4 WebKit Commit Bot 2015-12-03 15:04:39 PST

Attachment 266565 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/inspector/JSJavaScriptCallFrame.h:80:  GLOBAL_LEXICAL_ENVIRONMENT_SCOPE is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 1 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 5 Joseph Pecoraro 2015-12-03 15:26:11 PST

Comment on attachment 266565 [details]
[PATCH] Proposed Fix

Missed something.

Comment 6 Joseph Pecoraro 2015-12-03 15:34:47 PST

Created attachment 266568 [details]
[PATCH] Proposed Fix

Fixed Debug build ASSERTs by updating the protocol for runtime-checks.

Comment 7 Saam Barati 2015-12-03 18:19:04 PST

Comment on attachment 266568 [details]
[PATCH] Proposed Fix

LGTM

Comment 8 WebKit Commit Bot 2015-12-04 08:27:19 PST

Attachment 266568 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/inspector/JSJavaScriptCallFrame.h:80:  GLOBAL_LEXICAL_ENVIRONMENT_SCOPE is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 1 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 9 BJ Burg 2015-12-04 08:28:01 PST

Comment on attachment 266568 [details]
[PATCH] Proposed Fix

r=me too, assuming it passes EWS.

Comment 10 Joseph Pecoraro 2015-12-04 10:53:20 PST

<http://trac.webkit.org/changeset/193425>