Bug 151797

Summary: [GTK] Test /webkit2/WebKitWebResource/get-data is flaky
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: lforschler, mrobinson, pnormand, zan
Priority: P2 Keywords: Gtk
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mrobinson: review+

Carlos Garcia Campos
Reported 2015-12-03 00:09:43 PST
Since we switched to use the network process to run the unit tests the test /webkit2/WebKitWebResource/get-data sometimes fails and sometimes passes: ERROR:../../Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:194:void ResourcesTest::checkResourceData(WebKitWebResource*): code should not be reached FAIL This is because now the FIXME there doesn't seem to apply anymore: // FIXME: this should be 4 instead of 3, but we don't get the css image resource // due to bug https://bugs.webkit.org/show_bug.cgi?id=78510. test->waitUntilResourcesLoaded(3); We are now also getting the notification for the css image. Since we wait for 3 resources, sometimes the css image is loaded before and then checkResourceData is called for it, but not handled. When the css image is the last one loaded the test passes. So, we just need to wait for the 4 resources.
Attachments
Patch (2.74 KB, patch)
2015-12-03 00:13 PST, Carlos Garcia Campos 		mrobinson: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2015-12-03 00:13:55 PST
Created attachment 266515 [details] Patch
Carlos Garcia Campos
Comment 2 2015-12-03 23:45:28 PST
Committed r193412: <http://trac.webkit.org/changeset/193412>
Note You need to log in before you can comment on or make changes to this bug.