Bug 151790 – Uncaught Exception in Web Inspector: TypeError: null is not an object (evaluating 'dataGridNode.element.classList')

• Component: Web Inspector
• Status: RESOLVED FIXED

[Joseph Pecoraro]

* SUMMARY
Uncaught Exception in Web Inspector

TypeError: null is not an object (evaluating 'dataGridNode.element.classList') (at file:///Users/pecoraro/Build/Release/WebInspectorUI.framework/Resources/Views/TreeOutlineDataGridSynchronizer.js:282:29)

* STEPS TO REPRODUCE
1. Inspect about:blank
2. js> var i = 0; setInterval(function() { console.log("log", ++i); }, 1000)
3. Start a timeline
4. Select the JavaScript & Events timeline
5. Wait about 20 seconds (for the timeline to start scrolling and stuff)
  => Exception

[Radar WebKit Bug Importer]

<rdar://problem/23737405>

[Matt Baker]

Created attachment 266550 [details]
[Patch] Proposed Fix

[Timothy Hatcher]

Comment on attachment 266550 [details]
[Patch] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=266550&action=review

> Source/WebInspectorUI/UserInterface/Views/DataGrid.js:1331
> +        this._hidden = x;

x || false;

> Source/WebInspectorUI/UserInterface/Views/DataGrid.js:1333
> +            this._element.classList.toggle("hidden");

Should pass this._hidden as the second arg.

[Matt Baker]

Created attachment 266551 [details]
[Patch] Proposed Fix

[WebKit Commit Bot]

Comment on attachment 266551 [details]
[Patch] Proposed Fix

Clearing flags on attachment: 266551

Committed r193375: <http://trac.webkit.org/changeset/193375>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.