Bug 151790

Summary: Uncaught Exception in Web Inspector: TypeError: null is not an object (evaluating 'dataGridNode.element.classList')
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Matt Baker <mattbaker>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[Patch] Proposed Fix
none
[Patch] Proposed Fix none

Description Joseph Pecoraro 2015-12-02 20:41:48 PST
* SUMMARY
Uncaught Exception in Web Inspector

TypeError: null is not an object (evaluating 'dataGridNode.element.classList') (at file:///Users/pecoraro/Build/Release/WebInspectorUI.framework/Resources/Views/TreeOutlineDataGridSynchronizer.js:282:29)

* STEPS TO REPRODUCE
1. Inspect about:blank
2. js> var i = 0; setInterval(function() { console.log("log", ++i); }, 1000)
3. Start a timeline
4. Select the JavaScript & Events timeline
5. Wait about 20 seconds (for the timeline to start scrolling and stuff)
  => Exception
Comment 1 Radar WebKit Bug Importer 2015-12-02 20:42:13 PST
<rdar://problem/23737405>
Comment 2 Matt Baker 2015-12-03 13:07:48 PST
Created attachment 266550 [details]
[Patch] Proposed Fix
Comment 3 Timothy Hatcher 2015-12-03 13:13:35 PST
Comment on attachment 266550 [details]
[Patch] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=266550&action=review

> Source/WebInspectorUI/UserInterface/Views/DataGrid.js:1331
> +        this._hidden = x;

x || false;

> Source/WebInspectorUI/UserInterface/Views/DataGrid.js:1333
> +            this._element.classList.toggle("hidden");

Should pass this._hidden as the second arg.
Comment 4 Matt Baker 2015-12-03 13:17:22 PST
Created attachment 266551 [details]
[Patch] Proposed Fix
Comment 5 WebKit Commit Bot 2015-12-03 14:06:32 PST
Comment on attachment 266551 [details]
[Patch] Proposed Fix

Clearing flags on attachment: 266551

Committed r193375: <http://trac.webkit.org/changeset/193375>
Comment 6 WebKit Commit Bot 2015-12-03 14:06:34 PST
All reviewed patches have been landed.  Closing bug.