Bug 151775

Summary: Fix authentication requests with NetworkSession and canHandleHTTPSServerTrustEvaluation true
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch cdumez: review+

Alex Christensen
Reported 2015-12-02 14:20:10 PST
Fix authentication requests with NetworkSession and canHandleHTTPSServerTrustEvaluation true
Attachments
Patch (6.06 KB, patch)
2015-12-02 14:24 PST, Alex Christensen 		cdumez: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2015-12-02 14:24:27 PST
Created attachment 266471 [details] Patch
Alex Christensen
Comment 2 2015-12-02 15:17:12 PST
rdar://problem/23586265
Chris Dumez
Comment 3 2015-12-02 15:18:38 PST
Comment on attachment 266471 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=266471&action=review r=me with suggestion > Source/WebKit2/NetworkProcess/NetworkLoad.cpp:-284 > - notImplemented(); I would just do a: "auto completionHandler = WTF::move(m_completionHandler);" here, to avoid having to nullify m_completionHandler in all the branches.
Alex Christensen
Comment 4 2015-12-02 15:51:30 PST
http://trac.webkit.org/changeset/192982
Note You need to log in before you can comment on or make changes to this bug.