Bug 151764 – Fix social meta for home page

• Component: WebKit Website
• Status: RESOLVED FIXED

[Jon Davis]

The social meta for schema.org, Twitter Card and Open Graph is not useful for the homepage.

[Jon Davis]

Created attachment 266824 [details]
Patch

[Timothy Hatcher]

Comment on attachment 266824 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=266824&action=review

> Websites/webkit.org/wp-content/plugins/social-meta.php:42
> +<?php if ( '' !== ( $twitter_handle = get_the_author_meta('twitter') ) ): ?>

The reverse order reads better to me.

($twitter_handle = get_the_author_meta('twitter')) != ""

Do you even need the != ""? Empty string is false in PHP. Just the extra () should work.

The mix of ' and " bothers me too.

[Timothy Hatcher]

Comment on attachment 266824 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=266824&action=review

> Websites/webkit.org/wp-content/plugins/social-meta.php:14
> +        $type = "article";

I forgot single vs double quotes have differences in PHP, unlike JS.  These string here should likely be single quoted to match other static strings.

[Jon Davis]

Created attachment 266900 [details]
Patch

[Jon Davis]

Created attachment 266919 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 266919 [details]
Patch

Clearing flags on attachment: 266919

Committed r193772: <http://trac.webkit.org/changeset/193772>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.