Bug 151755

Summary: AX: AXObjectCacheMac is passing WebCore enum values directly to VoiceOver
Product: WebKit Reporter: Dominic Mazzoni <dmazzoni>
Component: AccessibilityAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, cfleizach, commit-queue, dbates, jcraig, jdiggs, mario, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Dominic Mazzoni
Reported 2015-12-02 10:33:24 PST
As one example, in AXObjectCacheMac.mm when it's populating the userInfo dictionary to pass to AXPostNotificationWithUserInfo: [userInfo setObject:[NSNumber numberWithInt:intent.type] forKey:NSAccessibilityTextStateChangeTypeKey]; However, intent.type is of type AXTextStateChangeType, an enum defined in WebCore/accessibility/AXTextStateChangeIntent.h, and that numeric value is being passed directly to VoiceOver without any translation. As it is now, adding a new enum value to AXTextStateChangeType (in cross-platform code) would probably break WebKit on Mac. In addition to separating the cross-platform constants from the Mac-specific constants, it'd be fantastic if you could document the protocol a bit more, since none of these keys appear in the 10.11 SDK or anywhere online yet. Thanks.
Attachments
Patch (9.97 KB, patch)
2016-01-06 14:24 PST, Doug Russell 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2015-12-02 10:33:36 PST
<rdar://problem/23726751>
Doug Russell
Comment 2 2016-01-06 14:24:35 PST
Created attachment 268407 [details] Patch
chris fleizach
Comment 3 2016-01-06 14:27:41 PST
Comment on attachment 268407 [details] Patch looks good
WebKit Commit Bot
Comment 4 2016-01-07 00:14:56 PST
Comment on attachment 268407 [details] Patch Clearing flags on attachment: 268407 Committed r194690: <http://trac.webkit.org/changeset/194690>
WebKit Commit Bot
Comment 5 2016-01-07 00:15:01 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.