Bug 151743

Summary: Move ResourceLoadScheduler to WebKit1
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Page LoadingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, cdumez, commit-queue, esprehn+autocc, japhet, kangil.han, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
patch
none
patch
none
patch
achristensen: review+
patch none

Description Antti Koivisto 2015-12-02 05:04:58 PST
It is no longer ever used by WebKit2. Simplify the WebKit/WebCore interface.
Comment 1 Radar WebKit Bug Importer 2015-12-02 05:21:56 PST
<rdar://problem/23723158>
Comment 2 Antti Koivisto 2015-12-02 05:22:18 PST
Created attachment 266437 [details]
patch
Comment 3 WebKit Commit Bot 2015-12-02 05:25:16 PST
Attachment 266437 [details] did not pass style-queue:


ERROR: Source/WebKit/WebCoreSupport/WebResourceLoadScheduler.cpp:25:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 1 in 32 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Antti Koivisto 2015-12-02 06:16:05 PST
Created attachment 266438 [details]
patch
Comment 5 WebKit Commit Bot 2015-12-02 06:18:31 PST
Attachment 266438 [details] did not pass style-queue:


ERROR: Source/WebKit/WebCoreSupport/WebResourceLoadScheduler.cpp:25:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 1 in 33 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Antti Koivisto 2015-12-02 06:47:46 PST
Created attachment 266440 [details]
patch
Comment 7 WebKit Commit Bot 2015-12-02 06:50:24 PST
Attachment 266440 [details] did not pass style-queue:


ERROR: Source/WebKit/WebCoreSupport/WebResourceLoadScheduler.cpp:25:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 1 in 33 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 Antti Koivisto 2015-12-02 11:11:51 PST
Created attachment 266456 [details]
patch
Comment 9 WebKit Commit Bot 2015-12-02 11:12:59 PST
Attachment 266456 [details] did not pass style-queue:


ERROR: Source/WebKit/WebCoreSupport/WebResourceLoadScheduler.cpp:25:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 1 in 38 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 10 Alex Christensen 2015-12-02 11:25:30 PST
Comment on attachment 266456 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=266456&action=review

r=me with comments.

> Source/WebCore/platform/PlatformStrategies.h:90
> +    CookiesStrategy* m_cookiesStrategy { };

Is this the cool new way to say { nullptr }?

> Source/WebKit2/WebProcess/Network/WebResourceLoadScheduler.cpp:294
> +    NetworkResourceLoadParameters loadParameters;

defersLoading, needsCertificateInfo, and maximumBufferingTime seem to be uninitialized.

> Source/WebKit2/WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:92
>  LoaderStrategy* WebPlatformStrategies::createLoaderStrategy()

These could probably be made to return references.

> Source/WebKit/WebCoreSupport/WebResourceLoadScheduler.cpp:64
> +    return static_cast<WebResourceLoadScheduler&>(*platformStrategies()->loaderStrategy());

Why is it ok to dereference this pointer?  I think this should be done differently.
Comment 11 Antti Koivisto 2015-12-02 11:28:01 PST
I'll do further cleanups separately.
Comment 12 Antti Koivisto 2015-12-03 03:23:24 PST
Created attachment 266525 [details]
patch
Comment 13 WebKit Commit Bot 2015-12-03 03:24:40 PST
Attachment 266525 [details] did not pass style-queue:


ERROR: Source/WebKit/WebCoreSupport/WebResourceLoadScheduler.cpp:25:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
ERROR: Source/WebKit/CMakeLists.txt:6:  Alphabetical sorting problem. "WebCoreSupport/WebResourceLoadScheduler.cpp" should be before "WebCoreSupport/WebViewGroup.cpp".  [list/order] [5]
Total errors found: 2 in 40 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 14 Antti Koivisto 2015-12-03 04:52:30 PST
https://trac.webkit.org/r192995