| Summary: | [Win] Run non-http tests without Cygwin | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Brent Fulgham <bfulgham> | ||||
| Component: | Tools / Tests | Assignee: | Brent Fulgham <bfulgham> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, glenn, lforschler | ||||
| Priority: | P2 | ||||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Brent Fulgham
2015-12-01 14:13:21 PST
Created attachment 266409 [details]
Patch
Attachment 266409 [details] did not pass style-queue:
ERROR: Tools/Scripts/webkitpy/port/win.py:231: [WinPort.read_registry_value] Undefined variable 'WindowsError' [pylint/E0602] [5]
ERROR: Tools/Scripts/webkitpy/port/win.py:257: [WinPort.write_registry_value] Undefined variable 'WindowsError' [pylint/E0602] [5]
ERROR: Tools/Scripts/webkitpy/port/win.py:261: [WinPort.write_registry_value] Undefined variable 'WindowsError' [pylint/E0602] [5]
Total errors found: 3 in 24 files
If any of these errors are false positives, please file a bug against check-webkit-style.
(In reply to comment #2) > Attachment 266409 [details] did not pass style-queue: > > > ERROR: Tools/Scripts/webkitpy/port/win.py:231: > [WinPort.read_registry_value] Undefined variable 'WindowsError' > [pylint/E0602] [5] > ERROR: Tools/Scripts/webkitpy/port/win.py:257: > [WinPort.write_registry_value] Undefined variable 'WindowsError' > [pylint/E0602] [5] > ERROR: Tools/Scripts/webkitpy/port/win.py:261: > [WinPort.write_registry_value] Undefined variable 'WindowsError' > [pylint/E0602] [5] > Total errors found: 3 in 24 files > > > If any of these errors are false positives, please file a bug against > check-webkit-style. These warnings are false positives. WindowsError is present in the native Windows Python implementation. Comment on attachment 266409 [details]
Patch
rs=me
Committed r192944: <http://trac.webkit.org/changeset/192944> |