Bug 151708

Summary: Need completionHandler-based WebKit C SPI for alert, confirm, and prompt
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch andersca: review+

Sam Weinig
Reported 2015-12-01 10:59:17 PST
Need completionHandler-based WebKit C SPI for alert, confirm, and prompt
Attachments
Patch (21.55 KB, patch)
2015-12-01 11:03 PST, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (22.42 KB, patch)
2015-12-01 11:35 PST, Sam Weinig 		andersca: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2015-12-01 11:03:51 PST
Created attachment 266367 [details] Patch
Sam Weinig
Comment 2 2015-12-01 11:35:10 PST
Created attachment 266371 [details] Patch
WebKit Commit Bot
Comment 3 2015-12-01 11:40:10 PST
Attachment 266371 [details] did not pass style-queue: ERROR: Tools/WebKitTestRunner/TestController.cpp:280: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebKit2/UIProcess/API/C/WKPage.cpp:1510: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/C/WKPage.cpp:1525: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/C/WKPage.cpp:1530: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/C/WKPage.cpp:1535: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/C/WKPage.cpp:1550: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/C/WKPage.cpp:1555: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/C/WKPage.cpp:1560: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/C/WKPage.cpp:1575: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/C/WKPage.cpp:1580: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 10 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 4 2015-12-01 13:41:20 PST
Attachment 266371 [details] did not pass style-queue: ERROR: Tools/WebKitTestRunner/TestController.cpp:280: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebKit2/UIProcess/API/C/WKPage.cpp:1510: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/C/WKPage.cpp:1525: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/C/WKPage.cpp:1530: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/C/WKPage.cpp:1535: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/C/WKPage.cpp:1550: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/C/WKPage.cpp:1555: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/C/WKPage.cpp:1560: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/C/WKPage.cpp:1575: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/C/WKPage.cpp:1580: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 10 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Sam Weinig
Comment 5 2015-12-01 14:10:07 PST
Committed revision 192911
Sam Weinig
Comment 6 2015-12-03 12:45:43 PST
Added missing function definitions in 193367.
Note You need to log in before you can comment on or make changes to this bug.