Bug 151708 - Need completionHandler-based WebKit C SPI for alert, confirm, and prompt
Summary: Need completionHandler-based WebKit C SPI for alert, confirm, and prompt
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-12-01 10:59 PST by Sam Weinig
Modified: 2015-12-03 12:45 PST (History)
1 user (show)

See Also:

Attachments
Patch (21.55 KB, patch)
2015-12-01 11:03 PST, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (22.42 KB, patch)
2015-12-01 11:35 PST, Sam Weinig 		andersca: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2015-12-01 10:59:17 PST 
Need completionHandler-based WebKit C SPI for alert, confirm, and prompt
Comment 1 Sam Weinig 2015-12-01 11:03:51 PST 
Created attachment 266367 [details]
Patch
Comment 2 Sam Weinig 2015-12-01 11:35:10 PST 
Created attachment 266371 [details]
Patch
Comment 3 WebKit Commit Bot 2015-12-01 11:40:10 PST 
Attachment 266371 [details] did not pass style-queue:


ERROR: Tools/WebKitTestRunner/TestController.cpp:280:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebKit2/UIProcess/API/C/WKPage.cpp:1510:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/API/C/WKPage.cpp:1525:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/API/C/WKPage.cpp:1530:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/API/C/WKPage.cpp:1535:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/API/C/WKPage.cpp:1550:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/API/C/WKPage.cpp:1555:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/API/C/WKPage.cpp:1560:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/API/C/WKPage.cpp:1575:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/API/C/WKPage.cpp:1580:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 10 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 WebKit Commit Bot 2015-12-01 13:41:20 PST 
Attachment 266371 [details] did not pass style-queue:


ERROR: Tools/WebKitTestRunner/TestController.cpp:280:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebKit2/UIProcess/API/C/WKPage.cpp:1510:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/API/C/WKPage.cpp:1525:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/API/C/WKPage.cpp:1530:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/API/C/WKPage.cpp:1535:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/API/C/WKPage.cpp:1550:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/API/C/WKPage.cpp:1555:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/API/C/WKPage.cpp:1560:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/API/C/WKPage.cpp:1575:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/API/C/WKPage.cpp:1580:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 10 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Sam Weinig 2015-12-01 14:10:07 PST 
Committed revision 192911
Comment 6 Sam Weinig 2015-12-03 12:45:43 PST 
Added missing function definitions in 193367.