Bug 151698

Summary: [Win] Small caps on web fonts have excess whitespace with the complex text code path
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: REOPENED ---    
Severity: Normal CC: bfulgham, buildbot, commit-queue, dino, jonlee, rniwa, simon.fraser, thorton
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 151738    
Bug Blocks: 149773    
Attachments:
Description Flags
Patch
darin: review+, buildbot: commit-queue-
Archive of layout-test-results from ews102 for mac-yosemite
none
Archive of layout-test-results from ews104 for mac-yosemite-wk2
none
Archive of layout-test-results from ews117 for mac-yosemite none

Description Myles C. Maxfield 2015-12-01 00:33:13 PST
[Win] Small caps have excess whitespace with the complex text codepath
Comment 1 Myles C. Maxfield 2015-12-01 00:40:22 PST
Created attachment 266341 [details]
Patch
Comment 2 Myles C. Maxfield 2015-12-01 00:45:22 PST
Comment on attachment 266341 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=266341&action=review

> Source/WebCore/ChangeLog:3
> +        [Win] Small caps have excess whitespace with the complex text codepath

Mention that this is only a problem for web fonts.
Comment 3 Build Bot 2015-12-01 01:25:48 PST
Comment on attachment 266341 [details]
Patch

Attachment 266341 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/500770

New failing tests:
fast/text/small-caps-complex.html
Comment 4 Build Bot 2015-12-01 01:25:50 PST
Created attachment 266344 [details]
Archive of layout-test-results from ews102 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 5 Build Bot 2015-12-01 01:29:11 PST
Comment on attachment 266341 [details]
Patch

Attachment 266341 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/500772

New failing tests:
fast/text/small-caps-complex.html
Comment 6 Build Bot 2015-12-01 01:29:14 PST
Created attachment 266345 [details]
Archive of layout-test-results from ews104 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 7 Build Bot 2015-12-01 03:32:29 PST
Comment on attachment 266341 [details]
Patch

Attachment 266341 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/501125

New failing tests:
fast/text/small-caps-complex.html
Comment 8 Build Bot 2015-12-01 03:32:31 PST
Created attachment 266351 [details]
Archive of layout-test-results from ews117 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 9 Myles C. Maxfield 2015-12-01 11:10:21 PST
Committed r192894: <http://trac.webkit.org/changeset/192894>
Comment 10 Myles C. Maxfield 2015-12-01 16:28:46 PST
It seems that this is crashy :(
Comment 11 Myles C. Maxfield 2015-12-01 19:19:57 PST
Build fix in r192904
Comment 12 WebKit Commit Bot 2015-12-01 19:21:20 PST
Re-opened since this is blocked by bug 151738
Comment 13 Myles C. Maxfield 2015-12-01 19:57:37 PST
Somewhat related: https://bugs.webkit.org/show_bug.cgi?id=151651