Summary: | Fix possible crash with animated layers in reflections | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||
Component: | New Bugs | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | dino, simon.fraser, thorton | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Simon Fraser (smfr)
2015-11-30 17:38:35 PST
Created attachment 266308 [details]
Patch
Comment on attachment 266308 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=266308&action=review > Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:3501 > + clearClonesOwner(m_layerClones.get()); > m_layerClones = nullptr; Since you are using a helper function, why not have it take std::unique_ptr<LayerMap>& and then it can do the nulling out too. |