Bug 151689

Summary:

Fix possible crash with animated layers in reflections

Product:

WebKit

Reporter:

Simon Fraser (smfr) <simon.fraser>

Component:

New Bugs

Assignee:

Simon Fraser (smfr) <simon.fraser>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dino, simon.fraser, thorton

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	darin: review+

Simon Fraser (smfr)

Reported 2015-11-30 17:38:35 PST

Fix possible crash with animated layers in reflections

Attachments
Patch (3.24 KB, patch) 2015-11-30 17:40 PST, Simon Fraser (smfr)	darin: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Simon Fraser (smfr)

Comment 1 2015-11-30 17:40:09 PST

Created attachment 266308 [details] Patch

Simon Fraser (smfr)

Comment 2 2015-11-30 17:40:24 PST

rdar://problem/23018612

Darin Adler

Comment 3 2015-11-30 17:57:09 PST

Comment on attachment 266308 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=266308&action=review > Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:3501 > + clearClonesOwner(m_layerClones.get()); > m_layerClones = nullptr; Since you are using a helper function, why not have it take std::unique_ptr<LayerMap>& and then it can do the nulling out too.

Simon Fraser (smfr)

Comment 4 2015-11-30 18:46:57 PST

https://trac.webkit.org/changeset/192853

Note You need to log in before you can comment on or make changes to this bug.