Bug 151687

Summary:

Add new library dependency for LLVMForJavaScriptCore dylib

Product:

WebKit

Reporter:

Juergen Ributzka <juergen>

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, ggaren, keith_miller, mark.lam, msaboff, saam

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none

Juergen Ributzka

Reported 2015-11-30 17:19:16 PST

Add new library dependency for LLVMForJavaScriptCore dylib

Attachments
Patch (4.69 KB, patch) 2015-11-30 17:23 PST, Juergen Ributzka	no flags	Details Formatted Diff Diff
Patch (4.69 KB, patch) 2015-12-01 11:25 PST, Juergen Ributzka	no flags	Details Formatted Diff Diff
Patch (3.29 KB, patch) 2015-12-01 11:38 PST, Juergen Ributzka	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Juergen Ributzka

Comment 1 2015-11-30 17:23:59 PST

Created attachment 266306 [details] Patch

Mark Lam

Comment 2 2015-12-01 09:35:26 PST

Comment on attachment 266306 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=266306&action=review r=me > Source/JavaScriptCore/ChangeLog:7 > + Adding this dependency should be backwards compatible, since LLVM has build and typo: build ==> built.

Geoffrey Garen

Comment 3 2015-12-01 09:49:48 PST

Have you tested that this change builds successfully with new and old LLVM?

Juergen Ributzka

Comment 4 2015-12-01 10:24:37 PST

Yes, I tried this with older LLVMs for iOS and OS X. The buildbots seems to be happy too and they are still using an older LLVM version.

Filip Pizlo

Comment 5 2015-12-01 11:17:45 PST

Comment on attachment 266306 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=266306&action=review > Source/JavaScriptCore/Configurations/LLVMForJSC.xcconfig:35 > -LLVM_LIBS_macosx = -lLLVMLinker -lLLVMipo -lLLVMVectorize -lLLVMIRReader -lLLVMBitReader -lLLVMAsmParser -lLLVMSelectionDAG -lLLVMAsmPrinter -lLLVMMCParser -lLLVMDebugInfo -lLLVMOption -lLLVMCodeGen -lLLVMScalarOpts -lLLVMInstCombine -lLLVMTransformUtils -lLLVMipa -lLLVMAnalysis -lLLVMMCDisassembler -lLLVMMCJIT -lLLVMTarget -lLLVMRuntimeDyld -lLLVMExecutionEngine -lLLVMMC -lLLVMObject -lLLVMCore -lLLVMSupport -lLLVMX86Disassembler -lLLVMX86CodeGen -lLLVMX86AsmParser -lLLVMX86Desc -lLLVMX86Info -lLLVMX86AsmPrinter -lLLVMX86Utils; > +LLVM_LIBS_macosx = -lLLVMInstrumentation -lLLVMLinker -lLLVMipo -lLLVMVectorize -lLLVMIRReader -lLLVMBitReader -lLLVMAsmParser -lLLVMSelectionDAG -lLLVMAsmPrinter -lLLVMMCParser -lLLVMDebugInfo -lLLVMOption -lLLVMCodeGen -lLLVMScalarOpts -lLLVMInstCombine -lLLVMTransformUtils -lLLVMipa -lLLVMAnalysis -lLLVMMCDisassembler -lLLVMMCJIT -lLLVMTarget -lLLVMRuntimeDyld -lLLVMExecutionEngine -lLLVMMC -lLLVMObject -lLLVMCore -lLLVMSupport -lLLVMX86Disassembler -lLLVMX86CodeGen -lLLVMX86AsmParser -lLLVMX86Desc -lLLVMX86Info -lLLVMX86AsmPrinter -lLLVMX86Utils; Is this change necessary?

Juergen Ributzka

Comment 6 2015-12-01 11:20:24 PST

Yes, this is a generic/target independent new dependency on this library.

Juergen Ributzka

Comment 7 2015-12-01 11:25:40 PST

Created attachment 266370 [details] Patch

Juergen Ributzka

Comment 8 2015-12-01 11:26:30 PST

Fixed typo.

Juergen Ributzka

Comment 9 2015-12-01 11:38:34 PST

Created attachment 266374 [details] Patch

Juergen Ributzka

Comment 10 2015-12-01 11:39:09 PST

Limit fix to iOS.

WebKit Commit Bot

Comment 11 2015-12-01 14:46:32 PST

Comment on attachment 266374 [details] Patch Clearing flags on attachment: 266374 Committed r192918: <http://trac.webkit.org/changeset/192918>

WebKit Commit Bot

Comment 12 2015-12-01 14:46:35 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.