Bug 151682 – CTTE autogenerated bindings code

• Component: New Bugs
• Status: RESOLVED FIXED

[Anders Carlsson]

CTTE autogenerated bindings code

[Anders Carlsson]

Created attachment 266297 [details]
Patch

[Anders Carlsson]

Created attachment 266303 [details]
Patch

[Darin Adler]

Comment on attachment 266303 [details]
Patch

There is so much more of this to be done in CodeGeneratorJS.pm, such as passing ExecState as a reference to most helpers.

[Anders Carlsson]

Committed r192849: <http://trac.webkit.org/changeset/192849>

[Csaba Osztrogonác]

Just to document: It broke the EFL build (not in WebKit2 code!)
Unfortunately EWS didn't process this patch, because an other
Apple employee broke the build previously against the red EWS bubble.

And the fix landed in https://trac.webkit.org/changeset/192860

[Csaba Osztrogonác]

And it broke the GTK build too as the EWS noticed it.

[Csaba Osztrogonác]

(In reply to comment #6)
> And it broke the GTK build too as the EWS noticed it.

just to document, fix landed in https://trac.webkit.org/changeset/192872

[Nikos Andronikos]

Also to document: This is causing the following type of error in the generated Objective-C code for partial interfaces:

webkit/WebKitBuild/Debug/DerivedSources/WebCore/DOMDocument.mm:443:65: error: non-const lvalue reference to type 'WebCore::Document' cannot bind to a temporary of type 'WebCore::Document *'
    return kit(WTF::getPtr(WebCore::DocumentAnimation::timeline(IMPL)));
                                                                ^~~~
webkit/WebKitBuild/Debug/DerivedSources/WebCore/DOMDocument.mm:106:14: note: expanded from macro 'IMPL'
#define IMPL static_cast<WebCore::Document*>(reinterpret_cast<WebCore::Node*>(_internal))

See bug 151739 for patch