Bug 151670

Summary: Fix the graphics benchmark complexity bounds adjustment
Product: WebKit Reporter: Said Abou-Hallawa <sabouhallawa>
Component: AnimationsAssignee: Said Abou-Hallawa <sabouhallawa>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, dino, rniwa, simon.fraser
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Said Abou-Hallawa
Reported 2015-11-30 12:45:34 PST
The test complexity bounds (min-max values) are used to prevent the test FPS from fluctuating. We always make sure the current complexity of the test is within these bounds. These bounds are the min-max values of the test complexity starting from the beginning of the first overshoot till the end of the following undershoot of the FPS. We need also to make sure that the bounds are large enough to allow some flexibility. This is helpful when the difference between the lower and upper bounds is very small. I think it is enough to make sure the lower bound is at least 90% of the upper bound. The bounds are negative in the case of graphics benchmark since the relationship between the test complexity and FPS is reverse proportional. So we need to apply the adjustment to the "absolute" minimum bound which is (min if min < 0) or (max if max < 0).
Attachments
Patch (1.62 KB, patch)
2015-11-30 12:49 PST, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Said Abou-Hallawa
Comment 1 2015-11-30 12:49:03 PST
Created attachment 266261 [details] Patch
WebKit Commit Bot
Comment 2 2015-11-30 15:06:43 PST
Comment on attachment 266261 [details] Patch Clearing flags on attachment: 266261 Committed r192835: <http://trac.webkit.org/changeset/192835>
WebKit Commit Bot
Comment 3 2015-11-30 15:06:46 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.