Bug 151656

Summary:

[EFL] Implement scheduleTimer and cancelTimer in IncrementalSweeper class

Product:

WebKit

Reporter:

Gyuyoung Kim <gyuyoung.kim>

Component:

JavaScriptCore

Assignee:

Gyuyoung Kim <gyuyoung.kim>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, keith_miller, mark.lam, msaboff, ossy, saam

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch for landing	none

Gyuyoung Kim

Reported 2015-11-30 08:40:44 PST

As mac and gtk ports, EFL ports supports IncremntalSweeper using Ecore_Timer.

Attachments
Patch (2.82 KB, patch) 2015-11-30 08:41 PST, Gyuyoung Kim	no flags	Details Formatted Diff Diff
Patch (3.13 KB, patch) 2015-12-01 00:36 PST, Gyuyoung Kim	no flags	Details Formatted Diff Diff
Patch (3.16 KB, patch) 2015-12-02 00:03 PST, Gyuyoung Kim	no flags	Details Formatted Diff Diff
Patch for landing (3.19 KB, patch) 2015-12-07 03:37 PST, Gyuyoung Kim	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Gyuyoung Kim

Comment 1 2015-11-30 08:41:51 PST

Created attachment 266246 [details] Patch

Gyuyoung Kim

Comment 2 2015-12-01 00:36:19 PST

Created attachment 266340 [details] Patch

Gyuyoung Kim

Comment 3 2015-12-01 05:34:36 PST

Comment on attachment 266340 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=266340&action=review > Source/JavaScriptCore/heap/IncrementalSweeper.cpp:79 > + if (m_isTimerFrozen) { I couldn't find an EFL function to check if timer is frozen. If there is any function to check it, please let me know.

Gyuyoung Kim

Comment 4 2015-12-02 00:03:20 PST

Created attachment 266434 [details] Patch

Csaba Osztrogonác

Comment 5 2015-12-07 03:32:45 PST

Comment on attachment 266434 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=266434&action=review LGTM, r=me with some comments. > Source/JavaScriptCore/heap/IncrementalSweeper.cpp:47 > -#if USE(CF) || (USE(GLIB) && !PLATFORM(EFL)) > +#if USE(CF) || USE(GLIB) I know that USE(GLIB) is true for us too, but it is a little bit confusing to rely on USE(GLIB) when we don't use GLIB timer here. I suggest using "#if USE(CF) || PLATFORM(EFL) || USE(GLIB)". It is redundant, but more descriptive and less confusing. > Source/JavaScriptCore/heap/IncrementalSweeper.h:52 > -#if USE(CF) || (USE(GLIB) && !PLATFORM(EFL)) > +#if USE(CF) || USE(GLIB) ditto

Gyuyoung Kim

Comment 6 2015-12-07 03:37:34 PST

Created attachment 266766 [details] Patch for landing

Gyuyoung Kim

Comment 7 2015-12-07 03:38:02 PST

Comment on attachment 266434 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=266434&action=review >> Source/JavaScriptCore/heap/IncrementalSweeper.cpp:47 >> +#if USE(CF) || USE(GLIB) > > I know that USE(GLIB) is true for us too, but it is a little bit > confusing to rely on USE(GLIB) when we don't use GLIB timer here. > > I suggest using "#if USE(CF) || PLATFORM(EFL) || USE(GLIB)". > It is redundant, but more descriptive and less confusing. Agreed.

WebKit Commit Bot

Comment 8 2015-12-07 08:51:33 PST

Comment on attachment 266766 [details] Patch for landing Clearing flags on attachment: 266766 Committed r193627: <http://trac.webkit.org/changeset/193627>

WebKit Commit Bot

Comment 9 2015-12-07 08:51:36 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.