Summary: | Modern IDB: Support updating cursor values when the object store uses inline keys | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brady Eidson <beidson> | ||||||||
Component: | WebCore Misc. | Assignee: | Brady Eidson <beidson> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | achristensen, alecflett, commit-queue, jsbell | ||||||||
Priority: | P2 | ||||||||||
Version: | Other | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 149117, 150882 | ||||||||||
Attachments: |
|
Description
Brady Eidson
2015-11-29 11:41:46 PST
Created attachment 266226 [details]
Patch v1
Comment on attachment 266226 [details]
Patch v1
This one relies on at least one of the other patches I have waiting in review, so unmarking for review at this time.
Created attachment 266249 [details]
Patch v1 (applies)
Well, apparently this doesn't apply, even though I just made it from trunk! Other stuff have probably landed since I updated. Created attachment 266252 [details]
Patch v1 (really applies)
Comment on attachment 266252 [details] Patch v1 (really applies) View in context: https://bugs.webkit.org/attachment.cgi?id=266252&action=review > Source/WebCore/Modules/indexeddb/client/IDBObjectStoreImpl.cpp:228 > + auto idbKey = scriptValueToIDBKey(state, key); You don't need to use a local variable here. |