Summary: | Find a replacement for -webkit-line-box-contain in mathml.css | ||
---|---|---|---|
Product: | WebKit | Reporter: | Frédéric Wang (:fredw) <fred.wang> |
Component: | MathML | Assignee: | Nobody <webkit-unassigned> |
Status: | NEW --- | ||
Severity: | Normal | CC: | ahmad.saleem792, alex, bfulgham, cfleizach, darin, jfernandez, mrobinson |
Priority: | P2 | ||
Version: | WebKit Nightly Build | ||
Hardware: | All | ||
OS: | All | ||
Bug Depends on: | 43819, 131839, 153991, 155433 | ||
Bug Blocks: |
Description
Frédéric Wang (:fredw)
2015-11-24 13:27:05 PST
(I forgot to mention that the -webkit-line-box-contain property was removed from Blink, so it's probably good to avoid relying on it anyway: https://code.google.com/p/chromium/issues/detail?id=522215) @Alex: I've done the proposed adjustment on your MathML branch, except that I kept "-webkit-line-box-contain: glyphs replaced;". Indeed, removing that one causes excessive ascent/descent and breaks tests. Upgrading the math test font to a version that has the USE_TYPO_METRICS flag gives a better result (see https://github.com/mrobinson/webkitgtk-test-fonts/issues/6) ; but using logical metrics still gives slightly taller ascent/descent than ink metrics [1]. So I suspect we will have to keep it for now and consider that again when the MathML layout code can really distinguish between logical/ink metrics. We will probably have to do something similar to Gecko (which does not support -webkit-line-box-contain) if we want to port the MathML code to Blink. [1] http://www.mathml-association.org/MathMLinHTML5/S3.html#SS1.SSS1 I moved the safe changes into bug 155433 and bug 155018. Let's keep this bug for the -webkit-line-box-contain rule only. |