Summary: | Modern IDB: When a transaction is aborted, call onerror handlers for all in-progress requests | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brady Eidson <beidson> | ||||||
Component: | WebCore Misc. | Assignee: | Brady Eidson <beidson> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | achristensen, alecflett, commit-queue, jsbell | ||||||
Priority: | P2 | ||||||||
Version: | Other | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 149117 | ||||||||
Attachments: |
|
Description
Brady Eidson
2015-11-22 10:49:32 PST
Created attachment 266061 [details]
Patch v1
Comment on attachment 266061 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=266061&action=review r=me except one comment. > Source/WebCore/Modules/indexeddb/shared/IDBError.cpp:117 > + static NeverDestroyed<String> entry = ASCIILiteral("Real description for abort"); This looks like you meant to get to this before uploading the patch. This tells me the error descriptions aren't checked in the tests. Will this be covered in https://bugs.webkit.org/show_bug.cgi?id=150402 (In reply to comment #2) > Comment on attachment 266061 [details] > Patch v1 > > View in context: > https://bugs.webkit.org/attachment.cgi?id=266061&action=review > > r=me except one comment. > > > Source/WebCore/Modules/indexeddb/shared/IDBError.cpp:117 > > + static NeverDestroyed<String> entry = ASCIILiteral("Real description for abort"); > > This looks like you meant to get to this before uploading the patch. Indeed! Yikes, and LOL. > This tells me the error descriptions aren't checked in the tests. Will this be > covered in https://bugs.webkit.org/show_bug.cgi?id=150402 Yup! 150402 will basically be a task that greps through the entire set of -expectations.txt to make sure each error desc shows up at least once, but 150882 is a pre-requisite for that. Coincidentally, 150882 is what I'm trying to work on over the next couple of days. Created attachment 266091 [details]
Patch for landing
Comment on attachment 266091 [details] Patch for landing Clearing flags on attachment: 266091 Committed r192749: <http://trac.webkit.org/changeset/192749> |