Bug 151507

Summary: Modern IDB: IDBTransaction::hasPendingActivity() was wrong, leading to premature GC of the wrapper
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebCore Misc.Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: ryanhaddad
Priority: P2    
Version: Safari 9   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch v1 bdakin: review+

Brady Eidson
Reported 2015-11-20 12:23:44 PST
Modern IDB: IDBTransaction::hasPendingActivity() was wrong, leading to premature GC of the wrapper Since the JS wrapper for an IDBTransaction might have been GC'ed before the transaction was done, javascript event callbacks to the transaction would fail. This would stall many tests, which would fail with a timeout. Because it's GC and therefore timing related, it showed up as flakiness. Known cases: https://bugs.webkit.org/show_bug.cgi?id=151219 https://bugs.webkit.org/show_bug.cgi?id=151364 https://bugs.webkit.org/show_bug.cgi?id=151389 https://bugs.webkit.org/show_bug.cgi?id=151448 However, the bug was fixed in https://trac.webkit.org/changeset/192687 So I suspect that all of these tests will un-flake going forward. I'll be closing all of those bugs as dupes of this one, and then once we're sure they've unflaked we can revert the TestExpectations changes made in each of those bugs.
Attachments
Patch v1 (1.85 KB, patch)
2015-12-08 16:04 PST, Brady Eidson 		bdakin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2015-11-20 12:24:26 PST
*** Bug 151219 has been marked as a duplicate of this bug. ***
Brady Eidson
Comment 2 2015-11-20 12:24:29 PST
*** Bug 151364 has been marked as a duplicate of this bug. ***
Brady Eidson
Comment 3 2015-11-20 12:24:32 PST
*** Bug 151389 has been marked as a duplicate of this bug. ***
Brady Eidson
Comment 4 2015-11-20 12:24:36 PST
*** Bug 151448 has been marked as a duplicate of this bug. ***
Brady Eidson
Comment 5 2015-12-08 16:02:26 PST
(In reply to comment #0) > Known cases: > https://bugs.webkit.org/show_bug.cgi?id=151219 > https://bugs.webkit.org/show_bug.cgi?id=151364 > https://bugs.webkit.org/show_bug.cgi?id=151389 > https://bugs.webkit.org/show_bug.cgi?id=151448 > > However, the bug was fixed in https://trac.webkit.org/changeset/192687 All of the tests marked flaky in those 4 bugs have unflaked since 192687.
Brady Eidson
Comment 6 2015-12-08 16:04:34 PST
Created attachment 266950 [details] Patch v1
Brady Eidson
Comment 7 2015-12-08 16:08:45 PST
https://trac.webkit.org/changeset/193792
Note You need to log in before you can comment on or make changes to this bug.