Bug 151502
| Summary: | [GTK] Non-symbolic icons used for edit-find and edit-clear | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Michael Catanzaro <mcatanzaro> |
| Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bugs-noreply, cgarcia, mcatanzaro |
| Priority: | P2 | ||
| Version: | Other | ||
| Hardware: | PC | ||
| OS: | Linux | ||
Michael Catanzaro
RenderThemeGtk.cpp improperly uses color icons in paintSearchFieldResultsDecorationPart(), paintSearchFieldCancelButton(), and paintCapsLockIndicator(). The proper icons would be edit-find-symbolic, edit-clear-symbolic, and dialog-warning-symbolic, respectively.
I tried to fix this by calling getStockSymbolicIconForWidgetType() rather than getStockIconForWidgetType() in those functions, but the icons in the search entry didn't display unless I removed the flag GTK_ICON_LOOKUP_FORCE_SIZE from the call to gtk_icon_theme_lookup_icon() in getStockSymbolicIconForWidgetType(), and then they displayed blurry, which is weird for symbolic icons, so I was doing something wrong.
Testcase for the search entry is to open the web inspector and look in the upper right.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Michael Catanzaro
Better testcase: the search box on https://www.wikipedia.org/
The magnifying glass icon should be monochrome, not blue.
Carlos Garcia Campos
Fixed in r194847