Bug 151426

Summary:

A window with a hung tab waits 5s before becoming active

Product:

WebKit

Reporter:

Geoffrey Garen <ggaren>

Component:

New Bugs

Assignee:

Geoffrey Garen <ggaren>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, bdakin, mitz, sam

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Geoffrey Garen 2015-11-18 18:06:00 PST

A window with a hung tab waits 5s before becoming active

Comment 1 Geoffrey Garen 2015-11-18 18:17:32 PST

Created attachment 265819 [details]
Patch

Comment 2 Anders Carlsson 2015-11-19 10:58:46 PST

Comment on attachment 265819 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=265819&action=review

> Source/WebKit2/UIProcess/Cocoa/WebViewImpl.mm:1163
> +    if (!mightBeginDragWhileInactive())
>          return false;

Should we check mightBeginScrollWhileInactive here too?

Comment 3 Geoffrey Garen 2015-11-19 11:28:13 PST

Comment on attachment 265819 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=265819&action=review

>> Source/WebKit2/UIProcess/Cocoa/WebViewImpl.mm:1163
>>          return false;
> 
> Should we check mightBeginScrollWhileInactive here too?

According to TextEdit's behavior, a scrollbar scroll that begins while the window is inactive will activate the window. In other words, scrolls do not delay window ordering. So, there's no need to check mightBeginScrollWhileInactive here.

Comment 4 Geoffrey Garen 2015-11-20 15:10:59 PST

Comment on attachment 265819 [details]
Patch

Clearing flags on attachment: 265819

Committed r192703: <http://trac.webkit.org/changeset/192703>

Comment 5 Geoffrey Garen 2015-11-20 15:11:02 PST

All reviewed patches have been landed.  Closing bug.