Bug 151404

Summary:

FTL OSR Exits that are exception handlers should not have two different entrances. Instead, we should have two discrete OSR exits that do different things.

Product:

WebKit

Reporter:

Saam Barati <saam>

Component:

JavaScriptCore

Assignee:

Saam Barati <saam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, fpizlo, ggaren, gskachkov, keith_miller, mark.lam, msaboff, oliver, sukolsak, ysuzuki

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	fpizlo: review+

Description Saam Barati 2015-11-18 14:02:43 PST

...

Comment 1 Saam Barati 2015-11-30 16:30:25 PST

Created attachment 266298 [details]
patch

Comment 2 Saam Barati 2015-11-30 16:41:45 PST

Comment on attachment 266298 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=266298&action=review

> Source/JavaScriptCore/ftl/FTLExceptionHandlerManager.cpp:95
>      auto findResult = m_map.find(stackmapRecordIndex);
>      if (findResult == m_map.end())

These should be m_callOperationMap and I've changed to that locally.

Comment 3 Saam Barati 2015-11-30 16:55:59 PST

landed in:
http://trac.webkit.org/changeset/192845