| Summary: | MediaStream: Implement MediaDevices.getSupportedConstraints | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Eric Carlson <eric.carlson> | ||||||||
| Component: | Media | Assignee: | Eric Carlson <eric.carlson> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | commit-queue, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 143211 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Eric Carlson
2015-11-18 10:43:39 PST
Created attachment 265758 [details]
Patch for the bots.
Attachment 265758 [details] did not pass style-queue:
ERROR: Source/WebCore/bindings/js/JSMediaTrackSupportedConstraintsCustom.cpp:55: Multi line control clauses should use braces. [whitespace/braces] [4]
ERROR: Source/WebCore/platform/mediastream/RealtimeMediaSourceCenter.cpp:39: Should have a space between // and comment [whitespace/comments] [4]
ERROR: Source/WebCore/platform/mediastream/RealtimeMediaSourceCenter.cpp:41: Should have a space between // and comment [whitespace/comments] [4]
ERROR: Source/WebCore/platform/mediastream/RealtimeMediaSourceCenter.cpp:54: Should have a space between // and comment [whitespace/comments] [4]
ERROR: Source/WebCore/platform/mediastream/RealtimeMediaSourceCenter.cpp:57: Should have a space between // and comment [whitespace/comments] [4]
Total errors found: 5 in 20 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 265772 [details]
Updated patch for the bots.
Attachment 265772 [details] did not pass style-queue:
ERROR: Source/WebCore/bindings/js/JSMediaTrackSupportedConstraintsCustom.cpp:55: Multi line control clauses should use braces. [whitespace/braces] [4]
Total errors found: 1 in 19 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 265777 [details]
Another updated patch.
Attachment 265777 [details] did not pass style-queue:
ERROR: Source/WebCore/bindings/js/JSMediaTrackSupportedConstraintsCustom.cpp:55: Multi line control clauses should use braces. [whitespace/braces] [4]
ERROR: Source/WebCore/PlatformGTK.cmake:687: Alphabetical sorting problem. "Modules/mediastream/MediaTrackSupportedConstraints.idl" should be before "Modules/mediastream/NavigatorMediaDevices.idl". [list/order] [5]
Total errors found: 2 in 20 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 265777 [details] Another updated patch. View in context: https://bugs.webkit.org/attachment.cgi?id=265777&action=review r=me. > Source/WebCore/platform/mediastream/RealtimeMediaSourceSupportedConstraints.h:51 > + , m_supportsGroupId(false) Why not use C++11 initializers down where you declare these guys? > Source/WebCore/platform/mock/MockRealtimeMediaSource.cpp:-87 > - Nice! :-) (In reply to comment #8) > Comment on attachment 265777 [details] > Another updated patch. > > View in context: > https://bugs.webkit.org/attachment.cgi?id=265777&action=review > > r=me. > > > Source/WebCore/platform/mediastream/RealtimeMediaSourceSupportedConstraints.h:51 > > + , m_supportsGroupId(false) > > Why not use C++11 initializers down where you declare these guys? > Good idea, done. Thanks! Committed r192602: https://trac.webkit.org/r192602 |