Bug 151394

Summary:

MediaStream: Implement MediaDevices.getSupportedConstraints

Product:

WebKit

Reporter:

Eric Carlson <eric.carlson>

Component:

Media

Assignee:

Eric Carlson <eric.carlson>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

143211

Attachments:

Description	Flags
Patch for the bots.	none
Updated patch for the bots.	none
Another updated patch.	bfulgham: review+

Eric Carlson

Reported 2015-11-18 10:43:39 PST

Implement it.

Attachments
Patch for the bots. (45.76 KB, patch) 2015-11-18 11:15 PST, Eric Carlson	no flags	Details Formatted Diff Diff
Updated patch for the bots. (44.46 KB, patch) 2015-11-18 12:17 PST, Eric Carlson	no flags	Details Formatted Diff Diff
Another updated patch. (45.02 KB, patch) 2015-11-18 14:14 PST, Eric Carlson	bfulgham: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2015-11-18 10:46:02 PST

<rdar://problem/23596124>

Eric Carlson

Comment 2 2015-11-18 11:15:35 PST

Created attachment 265758 [details] Patch for the bots.

WebKit Commit Bot

Comment 3 2015-11-18 12:03:20 PST

Attachment 265758 [details] did not pass style-queue: ERROR: Source/WebCore/bindings/js/JSMediaTrackSupportedConstraintsCustom.cpp:55: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebCore/platform/mediastream/RealtimeMediaSourceCenter.cpp:39: Should have a space between // and comment [whitespace/comments] [4] ERROR: Source/WebCore/platform/mediastream/RealtimeMediaSourceCenter.cpp:41: Should have a space between // and comment [whitespace/comments] [4] ERROR: Source/WebCore/platform/mediastream/RealtimeMediaSourceCenter.cpp:54: Should have a space between // and comment [whitespace/comments] [4] ERROR: Source/WebCore/platform/mediastream/RealtimeMediaSourceCenter.cpp:57: Should have a space between // and comment [whitespace/comments] [4] Total errors found: 5 in 20 files If any of these errors are false positives, please file a bug against check-webkit-style.

Eric Carlson

Comment 4 2015-11-18 12:17:55 PST

Created attachment 265772 [details] Updated patch for the bots.

WebKit Commit Bot

Comment 5 2015-11-18 12:29:50 PST

Attachment 265772 [details] did not pass style-queue: ERROR: Source/WebCore/bindings/js/JSMediaTrackSupportedConstraintsCustom.cpp:55: Multi line control clauses should use braces. [whitespace/braces] [4] Total errors found: 1 in 19 files If any of these errors are false positives, please file a bug against check-webkit-style.

Eric Carlson

Comment 6 2015-11-18 14:14:41 PST

Created attachment 265777 [details] Another updated patch.

WebKit Commit Bot

Comment 7 2015-11-18 14:16:31 PST

Attachment 265777 [details] did not pass style-queue: ERROR: Source/WebCore/bindings/js/JSMediaTrackSupportedConstraintsCustom.cpp:55: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebCore/PlatformGTK.cmake:687: Alphabetical sorting problem. "Modules/mediastream/MediaTrackSupportedConstraints.idl" should be before "Modules/mediastream/NavigatorMediaDevices.idl". [list/order] [5] Total errors found: 2 in 20 files If any of these errors are false positives, please file a bug against check-webkit-style.

Brent Fulgham

Comment 8 2015-11-18 17:12:46 PST

Comment on attachment 265777 [details] Another updated patch. View in context: https://bugs.webkit.org/attachment.cgi?id=265777&action=review r=me. > Source/WebCore/platform/mediastream/RealtimeMediaSourceSupportedConstraints.h:51 > + , m_supportsGroupId(false) Why not use C++11 initializers down where you declare these guys? > Source/WebCore/platform/mock/MockRealtimeMediaSource.cpp:-87 > - Nice! :-)

Eric Carlson

Comment 9 2015-11-18 17:25:01 PST

(In reply to comment #8) > Comment on attachment 265777 [details] > Another updated patch. > > View in context: > https://bugs.webkit.org/attachment.cgi?id=265777&action=review > > r=me. > > > Source/WebCore/platform/mediastream/RealtimeMediaSourceSupportedConstraints.h:51 > > + , m_supportsGroupId(false) > > Why not use C++11 initializers down where you declare these guys? > Good idea, done. Thanks!

Eric Carlson

Comment 10 2015-11-18 17:25:24 PST

Committed r192602: https://trac.webkit.org/r192602

Note You need to log in before you can comment on or make changes to this bug.