Bug 151377

Summary: Web Inspector: Watch Expressions details section should use NavigationBar
Product: WebKit Reporter: Matt Baker <mattbaker>
Component: Web InspectorAssignee: Matt Baker <mattbaker>
Severity: Normal CC: bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on: 151373    
Bug Blocks:    
Description Flags
[Patch] Proposed Fix
[Image] UI with navbar
UI looks weird none

Description Matt Baker 2015-11-17 19:07:59 PST
Watch Expressions details section should use NavigationBar. DOM elements for the add, remove and refresh buttons are currently added manually. The refresh and remove buttons should be disabled if no watch expressions exist.
Comment 1 Radar WebKit Bug Importer 2015-11-17 19:08:31 PST
Comment 2 Matt Baker 2015-11-17 19:37:36 PST
Created attachment 265730 [details]
[Patch] Proposed Fix
Comment 3 Matt Baker 2015-11-17 19:39:05 PST
Created attachment 265731 [details]
[Image] UI with navbar
Comment 4 WebKit Commit Bot 2015-11-18 13:36:45 PST
Comment on attachment 265730 [details]
[Patch] Proposed Fix

Clearing flags on attachment: 265730

Committed r192584: <http://trac.webkit.org/changeset/192584>
Comment 5 WebKit Commit Bot 2015-11-18 13:36:48 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 BJ Burg 2015-11-18 15:40:45 PST
Created attachment 265790 [details]
UI looks weird

This patch looks wrong on my machine (10.11.2)
Comment 7 BJ Burg 2015-11-18 15:41:08 PST
Comment 8 BJ Burg 2015-11-18 16:09:33 PST
(In reply to comment #7)
> Reopening.

Never mind, they were just landed in the wrong order.