Bug 151376

Summary: run-webkit-tests should not truncate persistent lines
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: Tools / TestsAssignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, glenn, koivisto, lforschler
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed fix koivisto: review+, commit-queue: commit-queue-

Alexey Proskuryakov
Reported 2015-11-17 18:00:28 PST
For whatever reason (or more precisely, to match ninja behavior), run-webkit-tests truncates its output, so that progress messages fit in one line. This is sort of OK for transient progress lines that get erased immediately, but not for what remains on the screen, especially for failures. rdar://problem/23162775
Attachments
proposed fix (3.05 KB, patch)
2015-11-17 18:08 PST, Alexey Proskuryakov 		koivisto: review+
commit-queue: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2015-11-17 18:08:30 PST
Created attachment 265725 [details] proposed fix
Antti Koivisto
Comment 2 2015-11-17 21:27:52 PST
Comment on attachment 265725 [details] proposed fix Nice, thanks!
WebKit Commit Bot
Comment 3 2015-11-17 22:14:24 PST
Comment on attachment 265725 [details] proposed fix Rejecting attachment 265725 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 265725, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: 151376. Found no modified ChangeLogs, cannot create a commit message. All changes require a ChangeLog. See: http://webkit.org/coding/contributing.html Found no modified ChangeLogs, cannot create a commit message. All changes require a ChangeLog. See: http://webkit.org/coding/contributing.html Found no modified ChangeLogs, cannot create a commit message. All changes require a ChangeLog. See: http://webkit.org/coding/contributing.html Updating OpenSource Current branch master is up to date. Full output: http://webkit-queues.webkit.org/results/444229
Alexey Proskuryakov
Comment 4 2015-11-17 22:27:33 PST
Oops. Landed manually in http://trac.webkit.org/r192565
Note You need to log in before you can comment on or make changes to this bug.