Bug 151373

Summary:

Web Inspector: Probes sidebar panel sections should use NavigationBar

Product:

WebKit

Reporter:

Matt Baker <mattbaker>

Component:

Web Inspector

Assignee:

Matt Baker <mattbaker>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

151377

Attachments:

Description	Flags
[Patch] Proposed Fix	none
[Patch] Proposed Fix	none
[Patch] Proposed Fix	none

Matt Baker

Reported 2015-11-17 17:11:29 PST

* SUMMARY Probes sidebar panel sections should use NavigationBar. Currently the add probe, clear samples, and remove probe buttons are added to the DOM manually, and lack tooltips and enabled/disabled state. The clear samples button should only be enabled when samples exist.

Attachments
[Patch] Proposed Fix (11.08 KB, patch) 2015-11-17 17:30 PST, Matt Baker	no flags	Details Formatted Diff Diff
[Patch] Proposed Fix (13.14 KB, patch) 2015-11-17 19:16 PST, Matt Baker	no flags	Details Formatted Diff Diff
[Patch] Proposed Fix (13.19 KB, patch) 2015-11-18 14:50 PST, Matt Baker	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2015-11-17 17:12:21 PST

<rdar://problem/23586395>

Matt Baker

Comment 2 2015-11-17 17:30:36 PST

Created attachment 265721 [details] [Patch] Proposed Fix

Matt Baker

Comment 3 2015-11-17 19:16:29 PST

Created attachment 265727 [details] [Patch] Proposed Fix

Blaze Burg

Comment 4 2015-11-18 13:16:05 PST

Comment on attachment 265727 [details] [Patch] Proposed Fix r=me

WebKit Commit Bot

Comment 5 2015-11-18 14:03:55 PST

Comment on attachment 265727 [details] [Patch] Proposed Fix Rejecting attachment 265727 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 265727, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: fs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 192583 = 2cdccd4e25f76b98954bfe31ba68605844034e38 r192584 = 355e1772eddb165f3350675b090fc6b42d9696df r192585 = d17e14a3625201fac8271edf221660edd2917f38 r192586 = cb5552d0076102582c50977bd8e82ce3e244a4d3 Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output: http://webkit-queues.webkit.org/results/446845

Matt Baker

Comment 6 2015-11-18 14:50:49 PST

Created attachment 265783 [details] [Patch] Proposed Fix

WebKit Commit Bot

Comment 7 2015-11-18 15:47:57 PST

Comment on attachment 265783 [details] [Patch] Proposed Fix Clearing flags on attachment: 265783 Committed r192594: <http://trac.webkit.org/changeset/192594>

WebKit Commit Bot

Comment 8 2015-11-18 15:48:00 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.