Summary: | Implement the B3 equivalent of FTLCompile | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Filip Pizlo <fpizlo> | ||||||
Component: | JavaScriptCore | Assignee: | Filip Pizlo <fpizlo> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | barraclough, benjamin, commit-queue, ggaren, keith_miller, mark.lam, mhahnenb, msaboff, oliver, saam, sam | ||||||
Priority: | P2 | ||||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Bug Depends on: | 151371 | ||||||||
Bug Blocks: | 150279 | ||||||||
Attachments: |
|
Description
Filip Pizlo
2015-11-17 16:40:40 PST
Created attachment 265724 [details]
work in progress
Created attachment 265784 [details]
the patch
Attachment 265784 [details] did not pass style-queue:
ERROR: Source/JavaScriptCore/ftl/FTLB3Compile.cpp:33: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 1 in 13 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 265784 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=265784&action=review > Source/JavaScriptCore/b3/B3Procedure.cpp:151 > +RegisterAtOffsetList& Procedure::calleeSaveRegisters() Maybe const? I can't think of a valid change on the returned value. const RegisterAtOffsetList& Procedure::calleeSaveRegisters() const (In reply to comment #4) > Comment on attachment 265784 [details] > the patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=265784&action=review > > > Source/JavaScriptCore/b3/B3Procedure.cpp:151 > > +RegisterAtOffsetList& Procedure::calleeSaveRegisters() > > Maybe const? I can't think of a valid change on the returned value. > const RegisterAtOffsetList& Procedure::calleeSaveRegisters() const True! :-) Landed in http://trac.webkit.org/changeset/192590 |