Bug 151358

Summary: Refactoring: move branchMul32's imm arg to the 3rd argument to be consistent.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, keith_miller, msaboff, saam
Priority: P2    
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch. saam: review+

Mark Lam
Reported 2015-11-17 13:59:23 PST
branch32, branchAdd32, and branchSub32 all have it as the 3rd argument. branchMul32 is the odd man out.
Attachments
proposed patch. (7.85 KB, patch)
2015-11-17 14:04 PST, Mark Lam 		saam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2015-11-17 14:04:07 PST
Created attachment 265706 [details] proposed patch.
Mark Lam
Comment 2 2015-11-17 14:04:57 PST
I've already built this patch successfully for ARMv7, ARM64, x86 and x86_64.
Saam Barati
Comment 3 2015-11-17 14:06:24 PST
Comment on attachment 265706 [details] proposed patch. r=me
Mark Lam
Comment 4 2015-11-17 14:09:40 PST
Thanks. Landed in r192535: <http://trac.webkit.org/r192535>.
Note You need to log in before you can comment on or make changes to this bug.