Bug 151342

Summary:

[JSC] Remove FTLOutput operations that act directly on floats

Product:

WebKit

Reporter:

Benjamin Poulain <benjamin>

Component:

New Bugs

Assignee:

Benjamin Poulain <benjamin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, fpizlo, keith_miller, mark.lam, msaboff, saam

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Benjamin Poulain 2015-11-16 23:06:01 PST

[JSC] Remove FTLOutput operations that act directly on floats

Comment 1 Benjamin Poulain 2015-11-16 23:06:15 PST

Created attachment 265665 [details]
Patch

Comment 2 Geoffrey Garen 2015-11-17 14:03:03 PST

Comment on attachment 265665 [details]
Patch

r=me

Comment 3 WebKit Commit Bot 2015-11-17 14:48:23 PST

Comment on attachment 265665 [details]
Patch

Clearing flags on attachment: 265665

Committed r192543: <http://trac.webkit.org/changeset/192543>

Comment 4 WebKit Commit Bot 2015-11-17 14:48:26 PST

All reviewed patches have been landed.  Closing bug.

Comment 5 Filip Pizlo 2015-12-09 20:13:08 PST

Comment on attachment 265665 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=265665&action=review

> Source/JavaScriptCore/ftl/FTLOutput.cpp:95
> +    if (refType == refFloat)
> +        value = buildFPCast(m_builder, value, floatType);

Is this really needed?

Comment 6 Filip Pizlo 2015-12-09 20:15:51 PST

Actually, seems like we should probably just roll this out now that B3 supports floats!