Bug 151334

Summary: Reorganize the graphics benchmark string table
Product: WebKit Reporter: Said Abou-Hallawa <sabouhallawa>
Component: AnimationsAssignee: Said Abou-Hallawa <sabouhallawa>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, dino, jonlee, rniwa, simon.fraser
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Said Abou-Hallawa
Reported 2015-11-16 17:53:57 PST
A string table was added to the benchmark to ease the separation of the code from the literal strings. The literal strings are used mainly in the results sections either in the results table or the JSON output. The current string table is an object of sub-string tables. Each sub-string table is an array of strings. Accessing the sub-string table array is cumbersome because it is difficult to know the returned string from its index unless you go back to the string table itself.
Attachments
Patch (20.75 KB, patch)
2015-11-16 18:29 PST, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
Patch (20.75 KB, patch)
2015-11-17 16:32 PST, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Said Abou-Hallawa
Comment 1 2015-11-16 18:29:46 PST
Created attachment 265648 [details] Patch
Simon Fraser (smfr)
Comment 2 2015-11-17 13:18:53 PST
Comment on attachment 265648 [details] Patch Much nicer!
Said Abou-Hallawa
Comment 3 2015-11-17 16:32:58 PST
Created attachment 265717 [details] Patch
WebKit Commit Bot
Comment 4 2015-11-17 17:29:20 PST
Comment on attachment 265717 [details] Patch Clearing flags on attachment: 265717 Committed r192559: <http://trac.webkit.org/changeset/192559>
WebKit Commit Bot
Comment 5 2015-11-17 17:29:25 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.