Bug 151312

Summary:

Web Inspector: delete-by-word and similar shortcuts should add text to the WebCore kill ring

Product:

WebKit

Reporter:

BJ Burg <bburg>

Component:

Web Inspector

Assignee:

BJ Burg <bburg>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, commit-queue, darin, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

See Also:

https://bugs.webkit.org/show_bug.cgi?id=151663

Bug Depends on:

151157

Bug Blocks:

Attachments:

Description	Flags
Proposed Fix	none

Description BJ Burg 2015-11-16 10:39:06 PST

Follow-up work for 151157 to address other uses of kill ring.

Comment 1 BJ Burg 2015-11-21 12:05:09 PST

Created attachment 266030 [details]
Proposed Fix

Comment 2 Radar WebKit Bug Importer 2015-11-21 12:05:32 PST

<rdar://problem/23642146>

Comment 3 Radar WebKit Bug Importer 2015-11-21 12:05:40 PST

<rdar://problem/23642148>

Comment 4 Darin Adler 2015-11-30 10:00:22 PST

Comment on attachment 266030 [details]
Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=266030&action=review

> Source/WebInspectorUI/UserInterface/Controllers/CodeMirrorTextKillController.js:44
> +        // FIXME: these keybindings match CodeMirror's default keymap for OS X.
> +        // They should probably be altered for Windows / Linux someday.

Unfortunate to have to hard code these like this. Generally speaking, Safari and WebKit respect the OS X system-wide key bindings <https://developer.apple.com/library/mac/documentation/Cocoa/Conceptual/EventOverview/TextDefaultsBindings/TextDefaultsBindings.html>.

Comment 5 WebKit Commit Bot 2015-11-30 10:27:08 PST

Comment on attachment 266030 [details]
Proposed Fix

Clearing flags on attachment: 266030

Committed r192804: <http://trac.webkit.org/changeset/192804>

Comment 6 WebKit Commit Bot 2015-11-30 10:27:13 PST

All reviewed patches have been landed.  Closing bug.

Comment 7 BJ Burg 2015-11-30 10:29:49 PST

(In reply to comment #4)
> Comment on attachment 266030 [details]
> Proposed Fix
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=266030&action=review
> 
> > Source/WebInspectorUI/UserInterface/Controllers/CodeMirrorTextKillController.js:44
> > +        // FIXME: these keybindings match CodeMirror's default keymap for OS X.
> > +        // They should probably be altered for Windows / Linux someday.
> 
> Unfortunate to have to hard code these like this. Generally speaking, Safari
> and WebKit respect the OS X system-wide key bindings
> <https://developer.apple.com/library/mac/documentation/Cocoa/Conceptual/
> EventOverview/TextDefaultsBindings/TextDefaultsBindings.html>.

Wow, I had no idea that this exists! I'll file a bug to see if we can integrate it.