Bug 151289

Summary:

Eliminate a request for layout every time an item is added to the stage of the graphics benchmark

Product:

WebKit

Reporter:

Said Abou-Hallawa <sabouhallawa>

Component:

Animations

Assignee:

Said Abou-Hallawa <sabouhallawa>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, commit-queue, dino, rniwa, simon.fraser

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Said Abou-Hallawa 2015-11-13 18:47:22 PST

The graphics item usually asks for the stage size when it is created. Because the stage size was not cached but rather was requested via clientWidth and clientHeight an implicit request for layout was invoked. This impact of this bug was very obvious when the benchmark was running with large fixed size in non adaptive mode. This was taking few seconds for benchmark to show the first animation frame.

Comment 1 Said Abou-Hallawa 2015-11-13 18:50:19 PST

Created attachment 265527 [details]
Patch

Comment 2 WebKit Commit Bot 2015-11-13 21:51:28 PST

Comment on attachment 265527 [details]
Patch

Clearing flags on attachment: 265527

Committed r192455: <http://trac.webkit.org/changeset/192455>

Comment 3 WebKit Commit Bot 2015-11-13 21:51:32 PST

All reviewed patches have been landed.  Closing bug.