Bug 151289

Summary: Eliminate a request for layout every time an item is added to the stage of the graphics benchmark
Product: WebKit Reporter: Said Abou-Hallawa <sabouhallawa>
Component: AnimationsAssignee: Said Abou-Hallawa <sabouhallawa>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, dino, rniwa, simon.fraser
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Said Abou-Hallawa
Reported 2015-11-13 18:47:22 PST
The graphics item usually asks for the stage size when it is created. Because the stage size was not cached but rather was requested via clientWidth and clientHeight an implicit request for layout was invoked. This impact of this bug was very obvious when the benchmark was running with large fixed size in non adaptive mode. This was taking few seconds for benchmark to show the first animation frame.
Attachments
Patch (2.58 KB, patch)
2015-11-13 18:50 PST, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Said Abou-Hallawa
Comment 1 2015-11-13 18:50:19 PST
Created attachment 265527 [details] Patch
WebKit Commit Bot
Comment 2 2015-11-13 21:51:28 PST
Comment on attachment 265527 [details] Patch Clearing flags on attachment: 265527 Committed r192455: <http://trac.webkit.org/changeset/192455>
WebKit Commit Bot
Comment 3 2015-11-13 21:51:32 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.